Maven Wrapper mvnw and mvnw.cmd built-in support #246

nhojpatrick · 2020-07-27T22:34:49Z

If mvnExecutable is blank, then automatically use mvnw or mvnw.cmd depending upon OS, if avaliable.

Tested on Mac, that if mvnw is present then the current working directory will be used instead of just mvn.

aleksandr-m · 2020-08-10T21:00:57Z

@nhojpatrick Have you tested this on Windows? I remember that there were some problems executing mvn.cmd instead of mvn on Windows.

nhojpatrick · 2020-09-05T21:32:02Z

@aleksandr-m tested on a windows 10 vm that didn't have mvn installed/setup, using Command Prompt

C:\john\aleksandr-m_gitflow-maven-plugin>mvnw com.amashchenko.maven.plugin:gitflow-maven-plugin:1.14.1-SNAPSHOT:release -DpostReleaseGoals=deploy
[INFO] Scanning for projects...
[INFO]
[INFO] ---------< com.amashchenko.maven.plugin:gitflow-maven-plugin >----------
[INFO] Building gitflow-maven-plugin 1.14.1
[INFO] ----------------------------[ maven-plugin ]----------------------------
[INFO]
[INFO] --- gitflow-maven-plugin:1.14.1-SNAPSHOT:release (default-cli) @ gitflow-maven-plugin ---
[INFO] Checking for uncommitted changes.
[INFO] Fetching remote branch 'origin develop'.
[WARNING] There were some problems fetching remote branch 'origin develop'. You can turn off remote branch fetching by setting the 'fetchRemote' parameter to false.
[INFO] Fetching remote branch 'origin master'.
[INFO] Comparing local branch 'master' with remote 'origin/master'.
[INFO] Checking out 'develop' branch.
[INFO] Checking for SNAPSHOT versions in dependencies.
[INFO] Cleaning and testing the project.
What is release version? [1.14.1]:
[INFO] Version is blank. Using default version.
[INFO] Checking out 'master' branch.
[INFO] Merging (--no-ff) 'develop' branch.
[INFO] Creating '1.14.1' tag.
[INFO] Running Maven goals: deploy
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  47.233 s
[INFO] Finished at: 2020-09-05T22:27:01+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.amashchenko.maven.plugin:gitflow-maven-plugin:1.14.1-SNAPSHOT:release (default-cli) on project gitflow-maven-plugin: release: [INFO] Scanning for projects...
[ERROR] [INFO]
[ERROR] [INFO] ---------< com.amashchenko.maven.plugin:gitflow-maven-plugin >----------
[ERROR] [INFO] Building gitflow-maven-plugin 1.14.1
[ERROR] [INFO] ----------------------------[ maven-plugin ]----------------------------
...
...
...
[ERROR] [INFO] ------------------------------------------------------------------------
[ERROR] [INFO] BUILD FAILURE
[ERROR] [INFO] ------------------------------------------------------------------------
[ERROR] [INFO] Total time:  12.125 s
[ERROR] [INFO] Finished at: 2020-09-05T22:27:01+01:00
[ERROR] [INFO] ------------------------------------------------------------------------
[ERROR] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy (default-deploy) on project gitflow-maven-plugin: Failed to deploy artifacts: Could not transfer artifact com.amashchenko.maven.plugin:gitflow-maven-plugin:jar:1.14.1 from/to sonatype-nexus-staging (https://oss.sonatype.org/service/local/staging/deploy/maven2/): Transfer failed for https://oss.sonatype.org/service/local/staging/deploy/maven2/com/amashchenko/maven/plugin/gitflow-maven-plugin/1.14.1/gitflow-maven-plugin-1.14.1.jar 401 Unauthorized -> [Help 1]
[ERROR] [ERROR]
[ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] [ERROR]
[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

Which errors because deploy doesn't have a valid username and password to actually upload as part of the deploy phase. So it must have found mvnw.cmd.

aleksandr-m · 2021-01-12T12:25:57Z

@nhojpatrick Can it be done in that way to use the same maven which user currently uses to run this plugin?
Something like if mvnExecutable is blank then see which maven had started plugin if wrapper then use it, if not then use the default.

nhojpatrick · 2021-01-17T17:40:33Z

@nhojpatrick Can it be done in that way to use the same maven which user currently uses to run this plugin?
Something like if mvnExecutable is blank then see which maven had started plugin if wrapper then use it, if not then use the default.

Using mavenSession.getSystemProperties() you can use;

env.JAVA_MAIN_CLASS_<PID>=org.apache.maven.wrapper.MavenWrapperMain vs env.JAVA_MAIN_CLASS_<PID>=org.codehaus.plexus.classworlds.launcher.Launcher
maven.home=/usr/local/Cellar/maven/3.6.3_1/libexec vs maven.home=/Users/USERNAME/.m2/wrapper/dists/apache-maven-3.6.3-bin/HASH/apache-maven-3.6.3

So @aleksandr-m any preference in a pattern match for env key env.JAVA_MAIN_CLASS_* with value org.apache.maven.wrapper.MavenWrapperMain, or key maven.home with value pattern .*/wrapper/dists/.*?

Working on testing both but it looks like both approaches can be used on a mac using maven 3.6.3.

nhojpatrick · 2021-01-17T19:25:25Z

@aleksandr-m decided to use both main class check and maven home check to determine if triggered by mvnw.

I think this is now ready to be merged.

Also noticed extra config for maven-compiler-plugin, so use my goto global properties defaults for any maven project.

nhojpatrick · 2021-02-19T09:47:02Z

@aleksandr-m have done some more testing and believe it works on both linux and windows, as well for builds within openshift and other cicd tools that default to mvnw if it's present.

nhojpatrick · 2021-03-18T18:50:30Z

@aleksandr-m want to add you as a reviewer and request a review but don't have permissions to do that.

nhojpatrick · 2021-09-09T07:39:10Z

@aleksandr-m Could this be reviewed and hopefully merged please.

aleksandr-m · 2021-09-09T12:21:16Z

@nhojpatrick Can you revert changes to properties. I'm more comfortable with them as they are now. I'll try to find time to review this in a few days.

aleksandr-m

@nhojpatrick I don't see any env.JAVA_MAIN_CLASS in my setup, so mainClassIsMavenWrapper is always false. And the maven.home property can be overridden from the command line.
Can you think of any other way to determine if goal is running from the wrapper?

pom.xml

src/main/java/com/amashchenko/maven/plugin/gitflow/AbstractGitFlowMojo.java

aleksandr-m · 2021-09-13T15:27:56Z

@nhojpatrick I had more time to test this feature, and seems using sun.java.command property works fine, at least in oracle/openjdk. See 72da507. Thanks for the idea and initial code.

nhojpatrick force-pushed the feature/mvnw branch from 6e24801 to 9dc6699 Compare September 5, 2020 23:37

nhojpatrick force-pushed the feature/mvnw branch from 9dc6699 to 168d15c Compare December 28, 2020 23:04

nhojpatrick force-pushed the feature/mvnw branch from 168d15c to 6050979 Compare January 15, 2021 10:35

nhojpatrick force-pushed the feature/mvnw branch from 1a38f20 to 411d310 Compare January 17, 2021 20:20

nhojpatrick force-pushed the feature/mvnw branch from 411d310 to 4d77dc1 Compare January 29, 2021 10:09

nhojpatrick force-pushed the feature/mvnw branch from 4d77dc1 to ffb0432 Compare February 15, 2021 09:46

nhojpatrick force-pushed the feature/mvnw branch from ffb0432 to 8f0e783 Compare September 9, 2021 07:25

nhojpatrick added 3 commits September 9, 2021 08:26

Reduce maven-compiler-plugin config by using user properties

5fa0496

Maven Wrapper mvnw and mvnw.cmd built-in support

8cd93ac

Maven Wrapper detection

053a15c

nhojpatrick force-pushed the feature/mvnw branch from 8f0e783 to 053a15c Compare September 9, 2021 07:26

aleksandr-m self-requested a review September 11, 2021 09:07

aleksandr-m requested changes Sep 11, 2021

View reviewed changes

aleksandr-m closed this Sep 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Maven Wrapper mvnw and mvnw.cmd built-in support #246

Maven Wrapper mvnw and mvnw.cmd built-in support #246

nhojpatrick commented Jul 27, 2020

aleksandr-m commented Aug 10, 2020

nhojpatrick commented Sep 5, 2020

aleksandr-m commented Jan 12, 2021

nhojpatrick commented Jan 17, 2021

nhojpatrick commented Jan 17, 2021 •

edited

Loading

nhojpatrick commented Feb 19, 2021

nhojpatrick commented Mar 18, 2021

nhojpatrick commented Sep 9, 2021

aleksandr-m commented Sep 9, 2021

aleksandr-m left a comment •

edited

Loading

aleksandr-m commented Sep 13, 2021

Maven Wrapper mvnw and mvnw.cmd built-in support #246

Maven Wrapper mvnw and mvnw.cmd built-in support #246

Conversation

nhojpatrick commented Jul 27, 2020

aleksandr-m commented Aug 10, 2020

nhojpatrick commented Sep 5, 2020

aleksandr-m commented Jan 12, 2021

nhojpatrick commented Jan 17, 2021

nhojpatrick commented Jan 17, 2021 • edited Loading

nhojpatrick commented Feb 19, 2021

nhojpatrick commented Mar 18, 2021

nhojpatrick commented Sep 9, 2021

aleksandr-m commented Sep 9, 2021

aleksandr-m left a comment • edited Loading

Choose a reason for hiding this comment

aleksandr-m commented Sep 13, 2021

nhojpatrick commented Jan 17, 2021 •

edited

Loading

aleksandr-m left a comment •

edited

Loading